Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tiny-js-world task #615

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

Anatolii-Petrenko
Copy link
Contributor

tiny-js-world

Demo | Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations on your PR! 😎😎😎

Let's do some self-checks to fix most common issues and to make some improvements to the code before reviewers put their hands on the code.

Go through the requirements/most common mistakes linked below and fix the code as appropriate.

If you have any questions to requirements/common mistakes feel free asking them here or in Students' chat.

When you genuinely believe you are done put a comment stating that you have completed self-checks and fixed code accordingly.

Also, be aware, that if you would silently ignore this recommendation, a mentor can think that you are still working on fixes. And your PR will not be reviewed. 😒

Please, make sure that your code follows the requirements based on the most common mistakes as well as basic requirements from the original task.

Universal recommendations:

  • Make sure your code follows General Requirements
  • Use common sense or seek for an advice whenever requirements look ambiguous or unclear.

By the way, you may proceed to the next task before this one is reviewed and merged.

Sincerely yours,
Submissions Kottachecker 😺

@Anatolii-Petrenko
Copy link
Contributor Author

Self-checking done.

@OleksiyRudenko OleksiyRudenko added the self-check-done Student confirmed that self-checks against requirements/common-mistakes are done label Sep 20, 2022
Copy link
Member

@OleksiyRudenko OleksiyRudenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anatolii-Petrenko well done!

gender: "female",
hands: 2,
legs: 2,
saying: cat.saying,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that this will create a copy of the saying. So when we change a cat's saying, cat-woman won't get updated.

@OleksiyRudenko OleksiyRudenko merged commit d929c52 into kottans:main Sep 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
self-check-done Student confirmed that self-checks against requirements/common-mistakes are done task-TJSW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants