Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

port-sniffer task #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Vitaminvp
Copy link

It would be interesting to use async compose here, I tried but failed :(

@OleksiyRudenko
Copy link
Member

OleksiyRudenko commented Nov 2, 2019

@Vitaminvp please check your code with yarn run lint:js as required by CODE_QUALITY.md.

Build reports multiple errors.

Copy link
Member

@AMashoshyna AMashoshyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Please see my comments below.

submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/helpers.js Outdated Show resolved Hide resolved
@Vitaminvp Vitaminvp requested a review from AMashoshyna November 4, 2019 19:45
@Vitaminvp
Copy link
Author

Local tests have passed but on-line not, interesting behavior.

submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
submissions/Vitamin/port-sniffer/sniffer.js Outdated Show resolved Hide resolved
@Vitaminvp
Copy link
Author

Done

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants