New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add ports-sniffer by serphiy #31

Open

serphiy wants to merge 1 commit into kottans:master from serphiy:port-sniffer

serphiy commented Nov 11, 2019

I've read ./README.md and ./CODE_QUALITY.md carefully.

The code is checked by yarn run lint:js and linter reported no errors.

The code is submitted in its own sub-directory and in a dedicated feature branch.

Please, review.


          add ports sniffer

7e2e8de

Member

AMashoshyna commented Nov 11, 2019

Very good job with asynchronous queue and separation parameter parsing from validation! I'm taking a closer look at the code.

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet