Check for body missing @JsonObject annotation. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikeelde
force-pushed
the
add-body-linting
branch
from
a3e34ba
to
cbaa695
Compare
erikeelde
force-pushed
the
add-body-linting
branch
from
cbaa695
to
c5f7c26
Compare
kozaxinan
approved these changes
Sep 24, 2024
|
Thank you for your contributions. This is definitely a needed case. About not hanging json in body class, if you have a test case, I can look at it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it'd be better to do a separate detector for this? Also @Body are not checking for @JSON annotations - which is a difference from the rest of the checks. Maybe that check should be added?
I still felt that adding this is a step towards better coverage for the lint checks - even if not checking for @JSON annotations currently.