Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fn render should not format Kptfile and the fn config files used in a Kptfile #2101

Closed
mengqiy opened this issue May 25, 2021 · 3 comments · Fixed by #2376
Closed

fn render should not format Kptfile and the fn config files used in a Kptfile #2101

mengqiy opened this issue May 25, 2021 · 3 comments · Fixed by #2376
Assignees
Labels
area/hydrate triaged Issue has been triaged by adding an `area/` label
Milestone

Comments

@mengqiy
Copy link
Contributor

mengqiy commented May 25, 2021

We need to verify if eval has this issue too.

@mengqiy mengqiy added bug Something isn't working area/hydrate triaged Issue has been triaged by adding an `area/` label labels May 25, 2021
@mengqiy mengqiy added this to the v1.0 m3 milestone May 25, 2021
@mengqiy
Copy link
Contributor Author

mengqiy commented May 25, 2021

cc: @phanimarupaka

@mikebz mikebz added the size/M 2 day label May 25, 2021
@droot
Copy link
Contributor

droot commented May 25, 2021

This is by design. @phanimarupaka added the behavior recently.

@mengqiy why kpt render shouldn't format meta resources ?

@droot droot removed the bug Something isn't working label May 25, 2021
@mengqiy
Copy link
Contributor Author

mengqiy commented May 25, 2021

There are 2 resources in this context:

  • Kptfile
  • fn-config.yaml files that are referenced by Kptfile.

I don't have a strong opinion about formatting Kptfile.
But IMO fn-config.yaml files should be invariants. Formatting them generates noise when looking at the diff of a package.

@phanimarupaka phanimarupaka removed the size/M 2 day label May 26, 2021
@phanimarupaka phanimarupaka modified the milestones: v1.0 m3, v1.0 m4 Jun 14, 2021
@phanimarupaka phanimarupaka modified the milestones: v1.0 m3, v1.0 m4 Jun 21, 2021
@mikebz mikebz removed this from the v1.0 m4 milestone Jul 14, 2021
@phanimarupaka phanimarupaka added this to the v1.0.0-beta.2 milestone Jul 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/hydrate triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants