Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add option to set session id #113

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat: add option to set session id #113

merged 1 commit into from
Dec 7, 2023

Conversation

wsbrunson
Copy link
Member

Adds a sticky session id so when a session is created, getStorage uses the session id passed to it instead of generating a new unique id

@wsbrunson wsbrunson requested a review from a team as a code owner November 15, 2023 16:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dfe213) 41.36% compared to head (5ff3064) 41.32%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   41.36%   41.32%   -0.05%     
==========================================
  Files          13       13              
  Lines        1315     1314       -1     
==========================================
- Hits          544      543       -1     
  Misses        771      771              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsbrunson wsbrunson merged commit 84a30ac into main Dec 7, 2023
@wsbrunson wsbrunson deleted the session-id-sticky branch December 7, 2023 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants