Reduce occurrence of "Detected iframe close" error #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
reviewed
Apr 27, 2023
gregjopa
changed the title
gregjopa
changed the title
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 95.64% 95.59% -0.06%
==========================================
Files 18 18
Lines 1217 1225 +8
==========================================
+ Hits 1164 1171 +7
- Misses 53 54 +1
☔ View full report in Codecov by Sentry. |
gregjopa
approved these changes
May 1, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're seeing rare cases when we see
Detected iframe closebefore second render has a chance to finish in slow browsers with poor connection. With this change, we're adding an additional check before we decide to throw the error.Here is the example:
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L866
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
https://paypal.atlassian.net/browse/LI-7432