Skip to content

bau-0.90 #1774

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 26, 2024
Merged

bau-0.90 #1774

merged 5 commits into from
Nov 26, 2024

Conversation

FredericHeem
Copy link
Contributor

@FredericHeem FredericHeem commented Nov 16, 2024 •
edited
Loading

  • Update bau to 0.90

Ranking from 1.50 to 1.38

Screenshot 2024-11-16 at 14 36 56

@krausest
Copy link
Owner

Sorry, swap row isn't keyed yet. The test reported:

npm run isKeyed -- --headless true keyed/bau
Keyed test for swap failed. Swap must add the TRs that it removed, but there were 2 new nodes
bau-v0.90.0-keyed is keyed for 'run benchmark' and keyed for 'remove row benchmark' and non-keyed for 'swap rows benchmark' . It'll appear as non-keyed in the results

Can you take a look at it please?

@FredericHeem FredericHeem changed the title bau-0.90 keyed bau-0.90 Nov 18, 2024
@FredericHeem
Copy link
Contributor Author

Yes indeed, the implementation is non-keyed. The PR has been updated.

Screenshot 2024-11-18 at 09 39 41

@FredericHeem
Copy link
Contributor Author

faster swap by updating in-place:

Screenshot 2024-11-18 at 10 21 03

@leeoniya
Copy link
Contributor

(will probably need a #772 note)

@krausest krausest merged commit 1ae1514 into krausest:master Nov 26, 2024
@krausest
Copy link
Owner

Results will appear in the chrome 131 run (hopefully soon).
And I added the #772 note.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredericHeem @krausest @leeoniya