Skip to content

feat: add effector-react #725

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

sergeysova
Copy link

No description provided.

@sergeysova
Copy link
Author

@krausest ?

@krausest
Copy link
Owner

Sorry, I‘m a bit short of time. Maybe I find the time this weekend.

@krausest krausest added the merging started merging started (no more updates please) label May 2, 2020
@krausest
Copy link
Owner

krausest commented May 2, 2020

Sorry, bad news. React-effector is tapping into issue #694

npm run isKeyed -- --headless keyed/effector-react
Keyed test for swap failed. Swap must add the TRs that it removed, but there were 2 new nodes

This issue turned up not too long ago, so there are still a few frameworks that don't behave correctly, but I plan to push them into the non-keyed section of the table at some point in time.

Can you take a look at it and see if you can make it truly keyed?

@krausest krausest removed the merging started merging started (no more updates please) label May 2, 2020
@krausest
Copy link
Owner

Closing this PR due to inactivity. Please open a new PR when you've prepared a new implementation.

@krausest krausest closed this May 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants