Skip to content

Add hydro-js implementation non-keyed #880

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
May 2, 2021
Merged

Add hydro-js implementation non-keyed #880

merged 8 commits into from
May 2, 2021

Conversation

Krutsch
Copy link
Contributor

@Krutsch Krutsch commented Apr 26, 2021

I hope this is correct, let me know otherwise! 😊

@Krutsch
Copy link
Contributor Author

Krutsch commented Apr 28, 2021

#772 has been fixed. This can be merged. I will create another PR for a keyed version at some point :)

@krausest
Copy link
Owner

krausest commented May 2, 2021

I'm getting the following error. Can you take a look at it please?

root@df3f610a6606:/build/frameworks/non-keyed/hydro-js# npm run build-prod

> js-framework-benchmark-hydro-js@1.3.4 build-prod /build/frameworks/non-keyed/hydro-js
> html-bundle

file:///build/frameworks/non-keyed/hydro-js/node_modules/html-bundle/dist/bundle.js:16
import { serialize, parse, parseFragment } from "parse5";
                    ^^^^^
SyntaxError: The requested module 'parse5' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from 'parse5';
const { serialize, parse, parseFragment } = pkg;
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:97:21)
    at async ModuleJob.run (internal/modules/esm/module_job.js:135:5)
    at async Loader.import (internal/modules/esm/loader.js:178:24)

@Krutsch
Copy link
Contributor Author

Krutsch commented May 2, 2021

Thanks, I will check! Which node version are you using?

@Krutsch
Copy link
Contributor Author

Krutsch commented May 2, 2021

Should work now in node v10+

@krausest krausest merged commit 45ec8b0 into krausest:master May 2, 2021
@krausest
Copy link
Owner

krausest commented May 2, 2021

Thanks. That worked fine.
Results are updated: https://krausest.github.io/js-framework-benchmark/current.html

@Krutsch Krutsch changed the title Add hydro-js implementation Add hydro-js implementation non-keyed May 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants