Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch To CommonJs And Jest #3

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Switch To CommonJs And Jest #3

merged 1 commit into from
Sep 30, 2024

Conversation

coltenkrauter
Copy link
Contributor

Description

As React Native only supports CommonJs, I am adjusting this package to be such.

Type of Change

  • New feature
  • Bug fix
  • Chore
  • Configuration
  • Documentation
  • Refactoring
  • Hotfix
  • Security
  • GitFlow

Testing

  • Executed locally
  • Unit tests
  • Integration tests
  • Load tests
  • PR Status checks
  • Workflow execution (against non-default branch)
  • Other (explain)
  • Not worth it (explain)
  • Not applicable

Checklist

[Not required to be completed, just check off what you've done.]

  • Commits are reasonably sized and the commit message describes the changes well.
  • I have made corresponding changes to the documentation.
  • I have added unit tests for changes to business logic.
  • I have emitted metrics so our team can monitor the health of this system related to these changes.
  • I have added logs to ensure debugging is straight-forward when issues arise.
  • I have considered failure modes (e.g. major dependency becomes unavailable, bad data passed in).
  • I have added a comment to this PR to discuss any concerns/risks of these changes. This might include effects on performance, new dependencies, changes in behavior, or difficult things to test.
  • I have considered whether some of these changes should go into a shared package to increase code reusability.

@coltenkrauter coltenkrauter self-assigned this Sep 30, 2024
@coltenkrauter coltenkrauter merged commit 8d42915 into main Sep 30, 2024
1 check passed
@coltenkrauter coltenkrauter deleted the switch-to-cjs branch September 30, 2024 04:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant