Attach errors to NotFound exception to be able to always have the full error response available #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was a bit confused when looking at the NotFound Exception because the errors() method always returned an empty array. After a bit of research I found that you catched that specific exception in Messaging.php and created a new NotFound, but lost the errors array that was previously created by convertResponse(). A simple fix is to add back the errors to becauseTokenNotFound().
I only tested this in 5.x because of limitations (php 7.4 and Guzzle 6), but the problem seems to also be in 7.x.