Simplify convoluted Dynamic Link operations #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegamez
force-pushed
the
dynamic-links-refactoring
branch
from
9929157 to
5cdef41
Compare
Codecov Report
@@ Coverage Diff @@
## 7.x #810 +/- ##
=============================================
+ Coverage 68.58% 90.78% +22.20%
+ Complexity 1659 1596 -63
=============================================
Files 170 156 -14
Lines 4699 4549 -150
=============================================
+ Hits 3223 4130 +907
+ Misses 1476 419 -1057 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea was to be able to switch implementations in case there was a way to abstract Guzzle away. But let's be honest - as long as
google/authandgoogle/cloud-coreare using Guzzle, so do we 😅