Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix 919 quit to title freeze person #1030

Merged
merged 6 commits into from
Feb 16, 2021

Conversation

kreghek
Copy link
Owner

@kreghek kreghek commented Feb 15, 2021

Resolves #919

@kreghek kreghek added bug Something isn't working client Works on client labels Feb 15, 2021
@kreghek kreghek self-assigned this Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1030 (c539f88) into master (de1815f) will increase coverage by 0.80%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
+ Coverage   76.79%   77.60%   +0.80%     
==========================================
  Files         344      344              
  Lines        7655     7659       +4     
==========================================
+ Hits         5879     5944      +65     
+ Misses       1776     1715      -61     
Flag Coverage Δ
Zilon.Core.FunctionalTests 69.65% <60.00%> (+3.37%) ⬆️
Zilon.Core.UnitTests 46.77% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Zilon.Core/Zilon.Core/Players/HumanPlayer.cs 75.00% <50.00%> (-8.34%) ⬇️
...ore/Commands/Sector/SectorTransitionMoveCommand.cs 84.61% <66.66%> (-6.30%) ⬇️
...ilon.Core/Persons/Survival/SurvivalRandomSource.cs 80.00% <0.00%> (-20.00%) ⬇️
...on.Core/Zilon.Core/Tactics/ActorActUsageHandler.cs 82.21% <0.00%> (+0.48%) ⬆️
Zilon.Core/Zilon.Core/Tactics/Sector.cs 94.24% <0.00%> (+1.43%) ⬆️
...on.Core/Zilon.Core/MapGenerators/ChestGenerator.cs 95.95% <0.00%> (+2.02%) ⬆️
...on.Core/Zilon.Core/World/GlobeTransitionHandler.cs 78.72% <0.00%> (+2.12%) ⬆️
...on.Core/Zilon.Core/Tactics/Behaviour/AttackTask.cs 89.65% <0.00%> (+3.44%) ⬆️
...n.Core/Zilon.Core/MapGenerators/MapRegionHelper.cs 88.46% <0.00%> (+3.84%) ⬆️
...on.Core/Zilon.Bot.Players/Logics/LootLogicState.cs 93.47% <0.00%> (+4.34%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1815f...c539f88. Read the comment docs.

@kreghek kreghek merged commit 3b7a9b3 into master Feb 16, 2021
@kreghek kreghek deleted the fix-919-quit-to-title-freeze-person branch February 16, 2021 11:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working client Works on client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Next new game does not work
1 participant