Fix environment merge from server var #832
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes with PHP-FPM and Apache there is in the $_SERVER a key named "proxy-nokeepalive"
You can also define custom environment variables in your webserver and this variables will be passed to the global var $_SERVER (in Apache, try : SetEnv bad-name 1).
This environment variables could be named with a bad name for Linux/Windows environment variables.
In my webserver, when I use CompassFilter, the result is :
sh: 1: export: proxy-nokeepalive: bad variable name
The BaseNodeFilter has the same problem (use the BaseProcessFilter::mergeEnv method)
This fix check the var names before to add it in the environment of the process.