Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix environment merge from server var #832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leblanc-simon
Copy link

Sometimes with PHP-FPM and Apache there is in the $_SERVER a key named "proxy-nokeepalive"
You can also define custom environment variables in your webserver and this variables will be passed to the global var $_SERVER (in Apache, try : SetEnv bad-name 1).

This environment variables could be named with a bad name for Linux/Windows environment variables.

In my webserver, when I use CompassFilter, the result is :
sh: 1: export: proxy-nokeepalive: bad variable name

The BaseNodeFilter has the same problem (use the BaseProcessFilter::mergeEnv method)

This fix check the var names before to add it in the environment of the process.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant