Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update reference to scssphp with BC #897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sad270
Copy link

@sad270 sad270 commented Feb 4, 2020

scssphp has moved. This PR updates the composer recommendation.
This is same PR #892 with BC requested by @stof in this comment

Fix #896

@sad270 sad270 changed the title Update reference to scssphp Update reference to scssphp with BC Feb 4, 2020
@LukeTowers
Copy link

This has been implemented in the 2.0 branch of assetic-php/assetic. Until we tag 2.0, you can pull it in by using "assetic/framework": "dev-2.0/dev" in your composer.json files.

@sad270
Copy link
Author

sad270 commented Feb 6, 2020

Hi, @LukeTowers thanks for your work, but i need stable project with php 7.1 assetic-php/assetic need php 7.2 or higher

@LukeTowers
Copy link

@jaxwilko what are we using that requires PHP 7.2? Can we bump it down to 7.1?

@sad270
Copy link
Author

sad270 commented Feb 7, 2020

@LukeTowers Maybe it's better to enable the issue tab in assetic-php/assetic repository and create new issue "Bump php down to 7.1 or 7.0" and talk about this in this new issue :)

And add link to this new issue in this PR

Or you can add my PR in your Repository, and release a v1.5.0 and keep a v1 version who fix all issue of this repository without new feature or new php version :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempted to load class "Compiler" from namespace "Leafo\ScssPhp".
2 participants