Add abstract audio actions #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the notifying the raw gestures, notify the abstract actions. This gives much cleaner notifications, and gives a better understanding of what handWavey is interpreting/doing.
Having both styles together will be unplesant, and not particularly informative.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Until this time, audio notifications have been for notifying the user about what gestures they are performing.
The change
This PR implements abstract notifications for the actual actions being performed.
These will make the same noises regardless of which gestureLayout is being used, which will help migrating between gestureLayouts.
I've chosen audio notifications that sound pleasant when compatible actions happen together, and sound bad when likely-incompatible actions happen together. Eg:
The traditional notification styles still exist, and should remain compatible long term.
Important considerations