fix: Ensure delete.sh script works properly with implicit namespace (#…

…217)

#### Motivation

The `delete.sh` cleanup script currently doesn't require a namespace to be provided via the -n option and uses the current kubectl context's namespace otherwise. The `$namespace` variable wasn't set in this case however meaning later parts of the script might not work as intended.

#### Modifications

Ensure `$namespace` variable is set correctly either way.

#### Result

`delete.sh` script works properly when `-n` option isn't used.

Signed-off-by: Nick Hill <nickhill@us.ibm.com>

scripts/delete.sh

@@ -72,15 +72,19 @@ if [[ -n $path_to_configs ]]; then
   cd "$path_to_configs"
 fi
 
+old_namespace=$(kubectl config  get-contexts $(kubectl config current-context) |tail -1|awk '{ print $5 }')
+if [[ ! -n $old_namespace ]]; then
+  old_namespace="default"
+fi
+echo "current namespace: $old_namespace"
 if [[ -n $namespace ]]; then
-  old_namespace=$(kubectl config  get-contexts $(kubectl config current-context) |tail -1|awk '{ print $5 }')
-  if [[ ! -n $old_namespace ]]; then
-    old_namespace="default"
-  fi
-  echo "current namespace: $old_namespace"
   kubectl config set-context --current --namespace="$namespace"
+else
+  namespace=$old_namespace
 fi
 
+echo "deleting in namespace: $namespace"
+
 # Ensure the namespace is overridden for all the resources
 pushd default
 kustomize edit set namespace "$namespace"
@@ -134,6 +138,6 @@ kubectl delete -f dependencies/quickstart.yaml --ignore-not-found=true
 kubectl delete -f dependencies/fvt.yaml --ignore-not-found=true
 
 # Roll back to previous status
-if [[ -n $namespace ]]; then
+if [[ "$namespace" != "$old_namespace" ]]; then
   kubectl config set-context --current --namespace=${old_namespace}
 fi