chore: Rename webhook (HPA) #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: kserve/kserve#3063 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner
requested review from
Jooho and
sivanantha321
and removed request for
tjohnson31415
10 tasks
rafvasq
approved these changes
Aug 4, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ckadner
added a commit
that referenced
this pull request
Aug 7, 2023
Rename the `servingruntime.serving.kserve.io` validating webhook in ModelMesh to resolve a naming conflict in KServe Related kserve/kserve#3031 Related kserve/kserve#3061 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> (cherry picked from commit dbdb177)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to rename the
servingruntime.serving.kserve.iovalidating webhook in ModelMesh to resolve a naming conflict inkserve/kserve:https://github.com/kserve/kserve/actions/runs/5741094894/job/15561730774#step:10:209
kserve/kserve#3031 (comment)_
Modifications
Rename the
servingruntime.serving.kserve.iotomodelmesh-servingruntime.serving.kserve.io.Result
TBD
Related
FYI @sivanantha321 @Jooho