Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Git Info & Automatic config for circleci #31

Merged
merged 9 commits into from
Jan 4, 2015
Merged

Conversation

gitu
Copy link
Contributor

@gitu gitu commented Dec 29, 2014

Did some refactoring and attached some additional info from git

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.79%) when pulling 27c3cf8 on gitu:feature/circleci into 3f05917 on kt3k:master.

@gitu
Copy link
Contributor Author

gitu commented Dec 29, 2014

I also built a small test project that uses the modified plugin:
Coveralls
travis build on coveralls
circle build on coveralls



@Test
void testCreateFromEnvVarCircleci() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt3k are you able to explain why this line doesn't hit the branch https://coveralls.io/files/406445698#L26 ?
when running locally it does hit it nicecely when setting a break point

cheers flo

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using gradlew or local gradle?

I think the cobertura has a lot of irrational behaviours with groovy 2.x. (It was ok with groovy 1.8 (which is bundled with gradle 1.x)

@kt3k
Copy link
Owner

kt3k commented Dec 31, 2014

Thanks for the contribution!

For the moment I'm a bit busy for other things, then I need some days to review this change. Please wait.

Thanks,

kt3k added a commit that referenced this pull request Jan 4, 2015
Git Info & Automatic config for circleci
@kt3k kt3k merged commit ab446fe into kt3k:master Jan 4, 2015
@kt3k
Copy link
Owner

kt3k commented Jan 4, 2015

Sorry for the late response.

Thanks for the nice enhancement! I've released this version as v2.1.0 to Maven and Bintray.

Thank you very much!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants