sort/maintain-list-order: maintain original order when when scores are tied #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktr0731
reviewed
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 87.10% 87.13% +0.02%
==========================================
Files 5 5
Lines 543 544 +1
==========================================
+ Hits 473 474 +1
Misses 57 57
Partials 13 13 |
|
That |
ktr0731
approved these changes
May 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple slices have the same SmithWaterman score the order in which they appear are not preserved, this PR improves the sorting function to keep the original order