Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add missing feature gate on ConfigExt for no-features build #1549

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Jul 23, 2024

Motivation

Fixes #1548

Solution

In kube/src/lib.rs:L197,

Before

pub mod prelude {
    #[allow(unreachable_pub)] pub use crate::client::ConfigExt as _;
    ...
}

After

pub mod prelude {
    #[cfg(feature = "client")]
    #[allow(unreachable_pub)]
    pub use crate::client::ConfigExt as _;
    ...
}

@HoKim98 HoKim98 force-pushed the fix/add-missing-client-feature-cfg branch from 4c4be45 to 37f2735 Compare July 23, 2024 08:07
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
@HoKim98 HoKim98 force-pushed the fix/add-missing-client-feature-cfg branch from 37f2735 to 29dfc10 Compare July 23, 2024 08:52
@HoKim98
Copy link
Contributor Author

HoKim98 commented Jul 23, 2024

Re-committed to pass rust-fmt!

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7%. Comparing base (5b3b73d) to head (29dfc10).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1549   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files         79      79           
  Lines       7252    7252           
=====================================
  Hits        5487    5487           
  Misses      1765    1765           
Files Coverage Δ
kube/src/lib.rs 88.5% <ø> (ø)

@clux clux added the changelog-fix changelog fix category for prs label Jul 23, 2024
@clux clux changed the title fix(kube): add missing client feature cfg on ConfigExt add missing feature gate on ConfigExt for no-features build Jul 23, 2024
@clux clux merged commit 7b48aba into kube-rs:main Jul 23, 2024
17 checks passed
@clux
Copy link
Member

clux commented Jul 23, 2024

I'll do a patch release with this shortly.

EDIT: released in 0.93.1

@clux clux added this to the 0.93.1 milestone Jul 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.93] unresolved import crate::client
2 participants