Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add finalizers predicate filter #1560

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add finalizers predicate filter #1560

merged 1 commit into from
Aug 14, 2024

Conversation

ivan-kiselev
Copy link
Contributor

As per relevant discussion

@clux I had to relax hash constraints with + ?Sized as .finalizers() returns &[String] of unknown on compile time size and so compiler wasn't exactly happy about that, but doesn't seem to be affecting anything else.

Signed-off-by: Ivan Kiselev <ivan.kiselev@ditto.live>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sensible to me. Thanks a lot!

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.4%. Comparing base (e2ceea8) to head (05bb5e9).

Files Patch % Lines
kube-runtime/src/utils/predicate.rs 33.4% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1560     +/-   ##
=======================================
- Coverage   75.4%   75.4%   -0.0%     
=======================================
  Files         80      80             
  Lines       7288    7290      +2     
=======================================
  Hits        5495    5495             
- Misses      1793    1795      +2     
Files Coverage Δ
kube-runtime/src/utils/predicate.rs 71.0% <33.4%> (-2.3%) ⬇️

@clux clux added the changelog-add changelog added category for prs label Aug 14, 2024
@clux clux added this to the 0.94.0 milestone Aug 14, 2024
@clux clux merged commit 7ff120a into kube-rs:main Aug 14, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants