-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ensure watch_object
handles objects removed before init
#1577
Conversation
e97bc20
to
83d81ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
+ Coverage 75.3% 75.3% +0.1%
=======================================
Files 82 82
Lines 7323 7331 +8
=======================================
+ Hits 5511 5519 +8
Misses 1812 1812
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I think this makes sense. A couple of quick questions to make sure i understand properly.
…t isn't in any initial list fixes kube-rs#1576 Signed-off-by: Mark Ingram <mark@lincs.dev>
83d81ba
to
22abc45
Compare
…t isn't in any initial list - added a comment - resolved a nightly clippy - use a match guard instead of an nested if Signed-off-by: Mark Ingram <mark@lincs.dev>
22abc45
to
b49ab8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are clear, thank you!
watch_object
will include an item when the objec…watch_object
handles objects removed before init
Stream produced by
watch_object
will include an item when the object isn't in any initial listfixes #1576
Motivation
Solution
No tests! I see there are attempts already in this area underway, e.g. #1529
I would be happy to add tests if/when those tests land