Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gauge SelectableField by k8s 1.30 version #1610

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Danil-Grigorev
Copy link
Member

Motivation

A follow up on #1605 from discussion.

Solution

Skip generation of fields for crd() for pre-1.30 version of k8s-openapi

Potentially overlaps with #1609

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (1addf43) to head (2b5efb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1610   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files         82      82           
  Lines       7340    7340           
=====================================
  Hits        5524    5524           
  Misses      1816    1816           
Files with missing lines Coverage Δ
kube-derive/src/custom_resource.rs 81.2% <ø> (ø)

@clux clux added the changelog-fix changelog fix category for prs label Oct 18, 2024
@clux clux added this to the 0.97.0 milestone Oct 18, 2024
@Danil-Grigorev Danil-Grigorev marked this pull request as ready for review October 18, 2024 10:32
@clux clux merged commit 7526539 into kube-rs:main Oct 18, 2024
17 checks passed
@clux clux mentioned this pull request Nov 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants