Remove rand dependency in favor of tungstenite fn
#1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found https://docs.rs/tungstenite/latest/tungstenite/handshake/client/fn.generate_key.html which means we can let upstream tungstenite be in charge of bumping rand. Signed-off-by: clux <sszynrae@gmail.com>
clux
changed the title
rand dependency in favor of tungstenite fn
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
- Coverage 75.8% 75.8% -0.0%
=======================================
Files 84 84
Lines 7629 7626 -3
=======================================
- Hits 5779 5776 -3
Misses 1850 1850
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found tungstenite::handshake::client::generate_key which is blanket re-exported via tokio-tungstenite (which we already depend on under
wsfeature)we still use rand as a dev dependency, but less explicit things on users, and less re-implementing the same logic.