Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add kube::Api::get_metadata_opt_with #1708

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

sebsoto
Copy link
Contributor

@sebsoto sebsoto commented Feb 28, 2025

Adds the aforementioned method, allowing the use of get_metadata_opt() with an explicit ResourceVersion. This follows an existing pattern, as both get() and get_metadata() have *_with() variants.

Motivation

Addresses #1698

Solution

Adds kube::Api::get_metadata_opt_with

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (a0c043a) to head (e500a99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/api/core_methods.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1708     +/-   ##
=======================================
- Coverage   75.8%   75.8%   -0.0%     
=======================================
  Files         84      84             
  Lines       7745    7746      +1     
=======================================
  Hits        5866    5866             
- Misses      1879    1880      +1     
Files with missing lines Coverage Δ
kube-client/src/api/core_methods.rs 72.4% <0.0%> (-0.9%) ⬇️

Adds the aforementioned method, allowing the use of get_metadata_opt()
with an explicit ResourceVersion. This follows an existing pattern, as
both get() and get_metadata() have *_with() variants.

Signed-off-by: Sebastian Soto <ssoto@redhat.com>
@sebsoto sebsoto force-pushed the addGetMetadataOptWith branch from 8b1cff4 to e500a99 Compare February 28, 2025 22:28
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@clux clux added this to the 0.99.0 milestone Mar 1, 2025
@clux clux added the changelog-add changelog added category for prs label Mar 1, 2025
@clux clux merged commit 2cfd167 into kube-rs:main Mar 1, 2025
17 checks passed
@clux clux linked an issue Mar 1, 2025 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kube::Api::get_metadata_opt_with
2 participants