Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump json-patch to 4 use bundled jsonptr to 0.7 #1718

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Bump json-patch to 4 use bundled jsonptr to 0.7 #1718

merged 4 commits into from
Mar 11, 2025

Conversation

clux
Copy link
Member

@clux clux commented Mar 11, 2025

replaces #1701 and #1696.

These would originally need to be upgraded together.
But now json-patch re-exports jsonptr now so we can get rid of the direct dep (which is very rarely used).

Doing it this way means we don't have to take a pin on jsonptr and just use whatever json-patch is using, and hopefully we'll get less dependabot errors.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux linked an issue Mar 11, 2025 that may be closed by this pull request
@clux clux added this to the 0.99.0 milestone Mar 11, 2025
@clux clux added changelog-change changelog change category for prs dependencies upgrades to dependencies labels Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (10f6e8e) to head (bd60030).
Report is 5 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1718   +/-   ##
=====================================
  Coverage   76.1%   76.1%           
=====================================
  Files         84      84           
  Lines       7860    7860           
=====================================
  Hits        5977    5977           
  Misses      1883    1883           
Files with missing lines Coverage Δ
kube-core/src/admission.rs 61.2% <ø> (ø)
kube-runtime/src/finalizer.rs 0.0% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux clux changed the title Bump json-patch to 4 and jsonptr to 0.7 Bump json-patch to 4 and jsonptr to 0.7 Mar 11, 2025
clux added 2 commits March 11, 2025 11:55
to get rid of tied dependency

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Bump json-patch to 4 and jsonptr to 0.7 Bump json-patch to 4 use bundled jsonptr to 0.7 Mar 11, 2025
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review March 11, 2025 12:21
@clux clux merged commit 25868e7 into main Mar 11, 2025
17 checks passed
@clux clux deleted the json-patch4 branch March 11, 2025 12:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest json-patch release has broken kube-runtime
1 participant