Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vagrant: Failed if user neither defines DLV_PORT nor run make before vagrant up #324

Closed
elfadel opened this issue Sep 6, 2021 · 0 comments · Fixed by #323
Closed

Vagrant: Failed if user neither defines DLV_PORT nor run make before vagrant up #324

elfadel opened this issue Sep 6, 2021 · 0 comments · Fixed by #323
Labels
enhancement New feature or request

Comments

@elfadel
Copy link
Contributor

elfadel commented Sep 6, 2021

If the user doesn’t define DLV_RPORT variable during vagrant up and doesn't execute make beforehand, the vagrant up command failed with the following message:

There are errors in the configuration of this machine. Please fix
    the following errors and try again:
    
    vm:
    * Forwarded port definitions require a "host" and "guest" value
    * Ports to forward must be 1 to 65535

This PR prevents this failure by setting up default ports if the user doesn't specify anyone.

@elfadel elfadel added the enhancement New feature or request label Sep 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant