Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vagrant: Add default host fwd port #323

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Conversation

elfadel
Copy link
Contributor

@elfadel elfadel commented Sep 5, 2021

This PR should fix #324

@elfadel
Copy link
Contributor Author

elfadel commented Sep 5, 2021

@nam-jaehyun should I open an issue first?
If not, please review.

@nam-jaehyun
Copy link
Collaborator

DLV_RPORT is defined in the Makefile, and we're using "make vagrant-{up|ssh|destory}".

@nam-jaehyun
Copy link
Collaborator

you can raise an issue and finalize this PR.

@elfadel elfadel requested a review from nam-jaehyun September 6, 2021 05:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #323 (fad2eab) into master (efe9b2f) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   37.79%   37.43%   -0.36%     
==========================================
  Files          21       21              
  Lines        8943     8943              
==========================================
- Hits         3380     3348      -32     
- Misses       5216     5248      +32     
  Partials      347      347              
Impacted Files Coverage Δ
KubeArmor/core/dockerHandler.go 52.14% <0.00%> (-12.46%) ⬇️
KubeArmor/monitor/systemMonitor.go 32.50% <0.00%> (-0.39%) ⬇️
KubeArmor/core/kubeUpdate.go 49.72% <0.00%> (-0.19%) ⬇️
KubeArmor/feeder/policyMatcher.go 36.50% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe9b2f...fad2eab. Read the comment docs.

@nam-jaehyun nam-jaehyun merged commit e7f68e3 into kubearmor:master Sep 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vagrant: Failed if user neither defines DLV_PORT nor run make before vagrant up
3 participants