-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add native AppArmor policy support in KubeArmorPolicy #150
Conversation
@@ -296,6 +296,7 @@ type KubeArmorPolicySpec struct { | |||
// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster | |||
// Important: Run "make" to regenerate code after modifying this file | |||
|
|||
Apparmor string `json:"apparmor,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Apparmor after Resource.
KubeArmor/types/types.go
Outdated
@@ -384,6 +384,7 @@ type SecuritySpec struct { | |||
Tags []string `json:"tags,omitempty"` | |||
Message string `json:"message,omitempty"` | |||
|
|||
Apparmor string `json:"apparmor,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Apparmor after Resource.
Need testing outcomes including:
|
9186d13
to
01eaf73
Compare
Hi @nam-jaehyun. I have changed my commit as per your suggestions. For the tests I have tested these on few YAML files I created locally but I did not add them in this commit. I will let you know as soon as I finish with the testing outcomes with screenshots and overall steps. |
@oneiro-naut Good! Please let me know when you're done. |
Hi @nam-jaehyun . I have shared with you a document containing screenshots and some observations via email. |
01eaf73
to
2fbcf5f
Compare
This commit makes it possible for us to embed native apparmor rules in the YAML policy. It adds a new field in the spec called apparmor of type string. Fixes: kubearmor#54 Signed-off-by: Ayush Dwivedi <ayush.dwivedi@accuknox.com>
2fbcf5f
to
38fc028
Compare
Hi @nam-jaehyun . I have made the changes with adding empty newlines. |
If you're available, it would be good for you to pick #86. |
@nam-jaehyun I think @daemon1024 is already looking into this issue. |
@oneiro-naut It looks like.. |
Hi @nam-jaehyun . I have added the issue can you please review if the statement is stated correctly? Also please assign me to the same. |
This commit makes it possible for us to embed native apparmor rules in the YAML policy. It
adds a new field in the spec called apparmor of type string.
Fixes: #54