[bug] Fixed the panic for uninitialized docker daemon #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daemon1024 Please see the description! |
Manik2708
commented
Feb 1, 2025
|
@rksharma95 @Aryan-sharma11 @daemon1024 Please review! |
|
@Aryan-sharma11 Have made the changes, please review! |
Aryan-sharma11
force-pushed
the
panic
branch
2 times, most recently
from
617cf8d to
c3b3b99
Compare
Aryan-sharma11
requested changes
Feb 28, 2025
|
@Aryan-sharma11 Really sorry for the long wait, kindly review. I think if we don't want to destroy the daemon, then just returning on error will be enough. Please provide your suggestions to this! |
daemon1024
approved these changes
Mar 20, 2025
Aryan-sharma11
approved these changes
Mar 21, 2025
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
|
@Aryan-sharma11 @daemon1024 Cleaned the commit history! Please review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1948
Does this PR introduce a breaking change? No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
cc @daemon1024 I am not able to reproduce the error, please can you verify whether this change is able to avoid panic or help me in reproducing this panic
Checklist:
<type>(<scope>): <subject>