Update documentation to install latest version of bcc #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested changes
Feb 10, 2022
getting-started/kubearmor_vm.md
Outdated
| @@ -4,8 +4,10 @@ This recipe explains how to use KubeArmor directly on VM/Bare-Metal host and was | |||
|
|
|||
| ## Download and Install KubeArmor | |||
|
|
|||
| 1. Download the [latest release of KubeArmor](https://github.com/kubearmor/KubeArmor/releases) | |||
| 2. Install KubeArmor `sudo apt install ./kubearmor_${VER}_linux-amd64.deb` ... where VER is the kubearmor release version. This will automatically install the required dependencies. | |||
| 1. Install latest bcc from [source](https://github.com/iovisor/bcc/blob/master/INSTALL.md#source), based on the linux distribution you are using.`version 0.21.0 or greater` | |||
There was a problem hiding this comment.
We are yet to make a new release, but after our next release bpfcc-tools are automatically installed in our deb package! We would still need folks on ubuntu 18.04 to install BCC from source but I wouldn't suggest adding it as a step. Rather it would be better add a note/blockquoute after the second point stating
We automatically install
bpfcc-toolswith our package, your distribution might have an older version of BCC so consider installing BCC from source in case of errors...
Can improve the wording. But something in line with this is perhaps better imo.
|
Thanks a lot for the PR! Left a comment in review :) |
daemon1024
requested changes
Feb 10, 2022
getting-started/kubearmor_vm.md
Outdated
Comment on lines
10
to
11
| ##### Note: | ||
| We automatically install `bpfcc-tools` with our package, your distribution might have an older version of BCC so consider installing BCC from [source](https://github.com/iovisor/bcc/blob/master/INSTALL.md#source) in case of errors. |
There was a problem hiding this comment.
Suggested change
| ##### Note: | |
| We automatically install `bpfcc-tools` with our package, your distribution might have an older version of BCC so consider installing BCC from [source](https://github.com/iovisor/bcc/blob/master/INSTALL.md#source) in case of errors. | |
| > Note: We automatically install `bpfcc-tools` with our package, your distribution might have an older version of BCC so consider installing BCC from [source](https://github.com/iovisor/bcc/blob/master/INSTALL.md#source) in case of errors. |
Let's use a blockquote
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
nyrahul
approved these changes
Feb 11, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slayer321 sachin.maurya7666@gmail.com
fix #609