Fix config behaviour #639
Merged
Fix config behaviour #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly calling set, overrides config/env values with default values. This changes fixes that behaviour. Note unlike the standard precedence order, value of flags will be of overwritten by config/env Signed-off-by: daemon1024 <barun.acharya@accuknox.com>
Codecov Report
@@ Coverage Diff @@
## main #639 +/- ##
==========================================
+ Coverage 43.55% 43.58% +0.03%
==========================================
Files 24 24
Lines 8482 8482
==========================================
+ Hits 3694 3697 +3
+ Misses 4336 4335 -1
+ Partials 452 450 -2
Continue to review full report at Codecov.
|
nyrahul
approved these changes
Mar 3, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly calling set, overrides config/env values with default values. This change fixes that behaviour. Note unlike the standard precedence order, value of flags will be overwritten by config/env
Signed-off-by: daemon1024 barun.acharya@accuknox.com