Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

aggregator custom labels template #3670

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

jessegoodier
Copy link
Collaborator

@jessegoodier jessegoodier commented Sep 13, 2024

What does this PR change?

Adding aggregator custom labels template
It is a helm best practice, andwe need it for some monitoring requirements

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

added aggregator custom labels helm template

What risks are associated with merging this PR? What is required to fully test this PR?

NA, following best practices found in other helm charts

How was this PR tested?

Tested with and and without the additional label. Label does not impact selector.

Have you made an update to documentation? If so, please provide the corresponding PR.

added to values file, which is all we need.

Copy link
Collaborator Author

@jessegoodier jessegoodier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick v2.4

@thomasvn
Copy link
Member

This LGTM. It also seems to follow the existing pattern for adding labels to services.

{{- include "cost-analyzer.commonLabels" . | nindent 4 }}
{{- if .Values.service.labels }}
{{ toYaml .Values.service.labels | indent 4 }}
{{- end }}

{{- include "prometheus.server.labels" . | nindent 4 }}
{{- if .Values.prometheus.server.service.labels }}
{{ toYaml .Values.prometheus.server.service.labels | indent 4 }}
{{- end }}

{{- include "cost-analyzer.commonLabels" . | nindent 4 }}
{{- if .Values.service.labels }}
{{ toYaml .Values.service.labels | indent 4 }}
{{- end }}

@jessegoodier jessegoodier merged commit e65993f into develop Sep 13, 2024
19 checks passed
@jessegoodier jessegoodier deleted the custom-service-labels branch September 13, 2024 16:08
@jessegoodier
Copy link
Collaborator Author

/cherry-pick v2.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 13, 2024
jessegoodier added a commit that referenced this pull request Sep 13, 2024
aggregator custom labels template

Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants