-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
aggregator custom labels template #3670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick v2.4
This LGTM. It also seems to follow the existing pattern for adding labels to services. cost-analyzer-helm-chart/cost-analyzer/templates/cost-analyzer-service-template.yaml Lines 8 to 11 in 09bf88b
cost-analyzer-helm-chart/cost-analyzer/templates/prometheus-server-service.yaml Lines 11 to 14 in 09bf88b
cost-analyzer-helm-chart/cost-analyzer/templates/frontend-service-template.yaml Lines 8 to 11 in 09bf88b
|
/cherry-pick v2.4 |
aggregator custom labels template
aggregator custom labels template Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com>
What does this PR change?
Adding aggregator custom labels template
It is a helm best practice, andwe need it for some monitoring requirements
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
added aggregator custom labels helm template
What risks are associated with merging this PR? What is required to fully test this PR?
NA, following best practices found in other helm charts
How was this PR tested?
Tested with and and without the additional label. Label does not impact selector.
Have you made an update to documentation? If so, please provide the corresponding PR.
added to values file, which is all we need.