Handle pipeline versions #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 9, 2021 20:06
Before this change, calling get_pipeline_id with a non-existing ID would make the function run forever Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
KFP provides the APIs to upload pipeline versions. Each pipeline has a `name` and an `id` and has a list of versions, each one with its own `name` and `id` (unique across all KFP versions - not just within the context of the pipeline). Note: Since KFP does not provide a way to name the first version of a pipeline, when uploading one for the first time we do the following: 1. Upload pipeline. This also generates a new version with the same name as the pipeline 2. Create a new version with a Kale autogenerated hash 3. Delete the first, autogenerated, version Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Also remove ApiError exception handling since we don't expect to upload a pipeline with a conflicting name or version name. If this happens the should let the error propagate to the user. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
We don't expect Kubeflow to be deployed in a namespace other than 'kubeflow'. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
elikatsis
approved these changes
Apr 9, 2021
elikatsis
force-pushed
the
feature-stefano-up-pipeline-versions
branch
from
cda8cf3 to
dc982fe
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload and run pipelines using pipeline versions, instead of uploading
a new pipeline with a random name every time.
This affects how we create, upload, and run pipelines, since we always
need to specify both a pipeline ID/Name and a version ID/Name.