Various utils improvements #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 16, 2021 11:45
Add a function which detects if it is running inside a pod that is a KFP pipeline step. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Move `podutils.get_run_uuid` to kfputils.detect_run_uuid` and remove `podutils.KFP_RUN_ID_LABEL_KEY` since it was already defined in `kfputils`. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
When the PVC size is specified in plain bytes, the function `_parse_k8s_size` would break beacuse the `unit` group would end up being None. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
This change is not a long term solution of course, just a temporary fix to remove the RPC call. We should rethink the implementation of `list_volumes` and `replace_cloned_volumes` and how they are used by RPCs and backend alike. Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
Signed-off-by: Stefano Fioravanzo <stefano@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
elikatsis
force-pushed
the
feature-stefano-up-utils-improvements
branch
from
68b24c5 to
a7f7bb7
Compare
elikatsis
approved these changes
Apr 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some refactoring and bug fixing to some of our common util modules.