Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace already closed github.com/golang/mock with go.uber.org/mock #2356

Closed
tenzen-y opened this issue Jun 14, 2024 · 5 comments · Fixed by #2357
Closed

Replace already closed github.com/golang/mock with go.uber.org/mock #2356

tenzen-y opened this issue Jun 14, 2024 · 5 comments · Fixed by #2357
Assignees

Comments

@tenzen-y
Copy link
Member

What you would like to be added?

I would like to replace the already closed github.com/golang/mock with the new go.uber.org/mock as recommended in the following:

Update, June 2023: This repo and tool are no longer maintained. Please see go.uber.org/mock for a maintained fork instead.

https://github.com/golang/mock?tab=readme-ov-file#gomock

Additionally, we can improve the order dependencies integration tests using WithOverridableExpectations as we discussed here: #2350 (comment)

Why is this needed?

The github.com/golang/mock is no longer maintained.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@tenzen-y
Copy link
Member Author

@forsaken628 Could you comment with /assign to assign this issue to yourself?

@tenzen-y
Copy link
Member Author

/triage accepted

Copy link

@tenzen-y: The label(s) triage/accepted cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tenzen-y
Copy link
Member Author

/remove-lifecycle needs-triage

@forsaken628
Copy link
Contributor

/assign

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants