Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor: Extract pipeline_test.py into a shared file for reuse across workflows #2972

Conversation

akagami-harsh
Copy link
Contributor

@akagami-harsh akagami-harsh commented Feb 3, 2025

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

  • extracted python code from gh action files

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

…s workflows

Signed-off-by: Your Name <hpotpose62@gmail.com>
@juliusvonkohout
Copy link
Member

Thank you for the PR, lets see what our tests say.

@akagami-harsh
Copy link
Contributor Author

Thank you for the PR, lets see what our tests say.

some tests are failing, ill try to fix them ASAP

Signed-off-by: Your Name <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh force-pushed the commonize-python-code-from-gh-action branch from 5f7bbc2 to 2077a1d Compare February 3, 2025 19:08
Signed-off-by: Your Name <hpotpose62@gmail.com>
@akagami-harsh
Copy link
Contributor Author

@juliusvonkohout Could you please trigger the CI? Thanks.

@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2025
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f007cf7 into kubeflow:master Feb 4, 2025
9 checks passed
@akagami-harsh akagami-harsh deleted the commonize-python-code-from-gh-action branch February 5, 2025 07:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants