Fix KFP tensorboard no GCP permission #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind bug |
|
/lgtm |
|
Looks like the tests need to be fixed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Bobgy
added a commit
to Bobgy/manifests
that referenced
this pull request
Mar 5, 2020
Bobgy
added a commit
to Bobgy/manifests
that referenced
this pull request
Mar 31, 2020
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 8, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area pipelines
Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#4795
Description of your changes:
kf-usersa so it has GCP permissions.Checklist:
cd manifests/testsmake generate-changed-onlymake test/assign @jlewi
/cc @amygdala
This change is