-
Notifications
You must be signed in to change notification settings - Fork 34
implementation of mxnet operator API v1 #39
Conversation
Hi @wackxu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test @wackxu Can you split the commits? For example, we can put generated code (client-gen, defaulter-gen) in one commit then we can review the code that hand-written by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
/lgtm
Well I prefer adding e2e test for mxnet operator, too. But it is not in the scope of this PR. /cc @richardsliu |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: 6b710d00-8118-11e9-b9f1-63f75d62ea26 |
Done |
Yes, we need add e2e test and we can do this in follow pr. |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: 36fbd3f0-8124-11e9-b9f1-63f75d62ea26 |
@gaocegege The CI is green now. I think we can merge it first. And for API changes or bug fix that cherry pick from tf-operator could be done in the follow PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@suleisl2000 Need your approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suleisl2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an exact copy of the v1beta1 APIs and controller implementation. Future API changes will be made to the v1 sub-folders.
ref #36
/assign @suleisl2000 @gaocegege
This change is