Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor fixes to e2e test make targets #2242

Merged

Conversation

Tom-Newton
Copy link
Contributor

Purpose of this PR

Make it a little easier to get started running the e2e tests.

Proposed changes:

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly - I don't think there is need for an update.
  • I have added tests that prove my changes are effective or that my feature works - I don't think this is applicable.
  • Existing unit tests pass locally with my changes.

Additional Notes

@Tom-Newton Tom-Newton force-pushed the tomnewton/minor_makefile_fixes branch from cdaeee6 to 2c2a920 Compare October 13, 2024 14:38
@Tom-Newton Tom-Newton changed the title Minor fixes to e2e test make targets Minor fixes to e2e test make targets Oct 13, 2024
@ChenYi015
Copy link
Contributor

/lgtm

@ChenYi015
Copy link
Contributor

@Tom-Newton Thanks for fixing this.

@ChenYi015
Copy link
Contributor

There is a go lint error introduced in recent commits which fails the code check CI and has already been fixed. Could you do a rebase? Will merge this PR when all CI workflow has passed.

Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
@Tom-Newton Tom-Newton force-pushed the tomnewton/minor_makefile_fixes branch from 2c2a920 to 959005e Compare October 13, 2024 16:13
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 13, 2024
@Tom-Newton
Copy link
Contributor Author

Rebased for the CI fix

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 13, 2024
@google-oss-prow google-oss-prow bot merged commit 0607a6d into kubeflow:master Oct 13, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants