-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Minor fixes to e2e test make
targets
#2242
Minor fixes to e2e test make
targets
#2242
Conversation
cdaeee6
to
2c2a920
Compare
make
targets
/lgtm |
@Tom-Newton Thanks for fixing this. |
There is a go lint error introduced in recent commits which fails the code check CI and has already been fixed. Could you do a rebase? Will merge this PR when all CI workflow has passed. |
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
2c2a920
to
959005e
Compare
Rebased for the CI fix |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Purpose of this PR
Make it a little easier to get started running the e2e tests.
Proposed changes:
$(KIND)
so it uses thekind
that was automatically installed rather than trying to find it on system path.Change Category
Indicate the type of change by marking the applicable boxes:
Checklist
Before submitting your PR, please review the following:
Additional Notes