Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add permissions to controller serviceaccount to list and watch ingresses #2246

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tcassaert
Copy link
Contributor

Purpose of this PR

When in UI ingress creation is enabled, we need the list and watch permissions for Ingress resources.

W1014 09:43:21.777501      10 reflector.go:539] pkg/mod/k8s.io/client-go@v0.29.3/tools/cache/reflector.go:229: failed to list *v1.Ingress: ingresses.networking.k8s.io is forbidden: User "system:serviceaccount:spark-operator:spark-operator-controller" cannot list resource "ingresses" in API group "networking.k8s.io" at the cluster scope
E1014 09:43:21.777525      10 reflector.go:147] pkg/mod/k8s.io/client-go@v0.29.3/tools/cache/reflector.go:229: Failed to watch *v1.Ingress: failed to list *v1.Ingress: ingresses.networking.k8s.io is forbidden: User "system:serviceaccount:spark-operator:spark-operator-controller" cannot list resource "ingresses" in API group "networking.k8s.io" at the cluster scope

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Signed-off-by: Thomas Cassaert <tcassaert@inuits.eu>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 14, 2024
@google-oss-prow google-oss-prow bot merged commit f750974 into kubeflow:master Oct 14, 2024
8 checks passed
@tcassaert tcassaert deleted the controller-policyrules branch October 14, 2024 12:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants