Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make sure enable-ui-service flag is set to false when controller.uiService.enable is set to false #2261

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Roberdvs
Copy link
Contributor

Purpose of this PR

Fixes #2260

Proposed changes:

  • Set enable-ui-service flag to the value of controller.uiService.enable, defaults to true

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

…rvice.enable is set to false

Signed-off-by: Roberto Devesa <15369573+Roberdvs@users.noreply.github.com>
@ChenYi015
Copy link
Contributor

@Roberdvs Thanks for reporting the issue and fixing it.

@ChenYi015
Copy link
Contributor

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, ImpSy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1491550 into kubeflow:master Oct 18, 2024
8 checks passed
@Roberdvs
Copy link
Contributor Author

@ChenYi015 Thank you for the quick turnaround!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Disabling Web UI service in the Helm chart has no effect
3 participants