-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add workflow for releasing sparkctl binary #2264
Conversation
.github/workflows/release.yaml
Outdated
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: | ||
- linux | ||
- darwin | ||
arch: | ||
- amd64 | ||
- arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matrix here as no impact on the os / arch use since we rely on ubuntu-latest (linux/amd64)
But we could rely on go native capability to build cross-platform binaries by setting GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }}
as env var when running make build-sparkctl
I would also not recommend using matrix in that specific case because It create new runner for each variation and does not reuse the go build cache meaning that time we have to wait a full build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we could rely on go native capability to build cross-platform binaries by setting
GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }}
as env var when runningmake build-sparkctl
Make sense. Have added them as job envs.
I would also not recommend using matrix in that specific case because It create new runner for each variation and does not reuse the go build cache meaning that time we have to wait a full build time
It will truly create 4 different runners, but they will build sparkctl binary concurrently, so actually the whole waiting time is shorter.
c643aa3
to
b4843d6
Compare
Signed-off-by: Yi Chen <github@chenyicn.net>
b4843d6
to
52b1410
Compare
/assign @jacobsalway @ImpSy |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015, ImpSy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Purpose of this PR
Close #1009.
Proposed changes:
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes