This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
Watch properly decode resourceVersion from custom object response #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roycaihw
force-pushed
the
crd-watch
branch
4 times, most recently
from
69d7445 to
e824e81
Compare
yliaog
reviewed
Apr 27, 2018
watch/watch.py
Outdated
| # For custom objects that we don't have model defined, json | ||
| # deserialization results in dictionary | ||
| elif isinstance(js['object'], dict) and 'metadata' in js['object']: | ||
| self.resource_version = js['object']['metadata'][ |
There was a problem hiding this comment.
better to check whether 'resourceVersion' is present in js['object']['metadata']
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 93.36% 93.43% +0.07%
==========================================
Files 11 11
Lines 949 960 +11
==========================================
+ Hits 886 897 +11
Misses 63 63
Continue to review full report at Codecov.
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kubernetes-client/python#503
Watch deserializes a CR json response into a dictionary instead of an object of a class, because we don't have model defined for CR, and hasattr() doesn't work for dict. As a result watch failed to update resource_version from last response. This PR tries getting resource version if the response is deserialized into a dictionary.