-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Pass through empty newlines in watch stream #2359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Pass through empty newlines in watch stream #2359
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @marcelldls! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcelldls The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please sign the CLA |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Pass through empty newlines in watch stream
Which issue(s) this PR fixes:
Fixes #2358
Special notes for your reviewer:
I'm not sure if this guard was needed for watch events
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: