-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update go version to 1.14.4 #96
Conversation
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: humblec The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't think we came to a full conclusion on which Go version we want to switch to: Apparently 1.14 has potential runtime issues that are severe enough that Kubernetes is skipping it. |
We decided to go straight for 1.15, in order to be aligned with Kubernetes 1.19.0 and Docker which both skip 1.14 because of runtime issues (kubernetes/kubernetes#92521). |
PR #97 replaces this one here. |
@humblec: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close We went straight to Go 1.15 instead. |
@pohly: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Humble Chirammal hchiramm@redhat.com