Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update go version to 1.14.4 #96

Closed
wants to merge 1 commit into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 10, 2020

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot
Copy link
Contributor

@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec
To complete the pull request process, please assign pohly
You can assign the PR to them by writing /assign @pohly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali August 10, 2020 10:46
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2020
@pohly
Copy link
Contributor

pohly commented Aug 10, 2020

I don't think we came to a full conclusion on which Go version we want to switch to:
https://kubernetes.slack.com/archives/C8EJ01Z46/p1596537153179300

Apparently 1.14 has potential runtime issues that are severe enough that Kubernetes is skipping it.

@pohly
Copy link
Contributor

pohly commented Aug 12, 2020

We decided to go straight for 1.15, in order to be aligned with Kubernetes 1.19.0 and Docker which both skip 1.14 because of runtime issues (kubernetes/kubernetes#92521).

@pohly
Copy link
Contributor

pohly commented Aug 12, 2020

PR #97 replaces this one here.

@k8s-ci-robot
Copy link
Contributor

@humblec: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@pohly
Copy link
Contributor

pohly commented Aug 13, 2020

/close

We went straight to Go 1.15 instead.

@k8s-ci-robot
Copy link
Contributor

@pohly: Closed this PR.

In response to this:

/close

We went straight to Go 1.15 instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants