Add documentation for Secrets in the VolumeGroupSnapshotClass #609
Conversation
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
|
@nixpanic: GitHub didn't allow me to request PR reviews from the following users: yati1998. Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
cncf-cla: yes
|
v8.2.0 has been released. Once this PR is reviewed it can be merged too. |
|
|
||
| Note, however, that the delete operation will continue even if the secret is not found (because, for example, the entire namespace containing the secret was deleted). In this case, if the driver requires a secret for deletion, then the volume and PV may need to be manually cleaned up. | ||
|
|
||
| The values of these parameters may be "templates". The `external-snapshotter` will automatically resolve templates at snapshot create time, as detailed below: |
There was a problem hiding this comment.
snapshot create time to volume group snapshot create time
|
|
||
| If no such secret exists in the Kubernetes API, or the snapshotter is unable to fetch it, the create operation will fail. | ||
|
|
||
| Note, however, that the delete operation will continue even if the secret is not found (because, for example, the entire namespace containing the secret was deleted). In this case, if the driver requires a secret for deletion, then the volume and PV may need to be manually cleaned up. |
There was a problem hiding this comment.
then the volume and PV may need to be manually cleaned up. need to be updated to reflect volume group snapshot
There was a problem hiding this comment.
Modified it to then the volume group snapshot and related snapshots need to be manually cleaned up.
|
|
||
| If no such secret exists in the Kubernetes API, or the snapshotter is unable to fetch it, the create operation will fail. | ||
|
|
||
| The values of these parameters may be "templates". The `external-snapshotter` will automatically resolve templates at snapshot create time, as detailed below: |
There was a problem hiding this comment.
snapshot create time to group snapshot creation
nixpanic
force-pushed
the
volume-group-snapshot/secrets
branch
from
15a5ad7 to
aa2bf35
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@xing-yang PTAL |
|
/unassign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The Secrets that can be configured in the VolumeGroupSnapshotClass were not documented yet.
Note that the
external-snapshotterv8.2.0 is not released yet, the secret forGetGroupSnapshotRequestoperations depends on that.No release-note for this, versions are included in the text itself.
Depends-on: kubernetes-csi/external-snapshotter#1122