-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: update go to 1.23.6 #122
Conversation
Welcome @liangyuanpeng! |
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
hey @liangyuanpeng , Thanks for the pr. |
5c8f4bf
to
755bb65
Compare
755bb65
to
bc17bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another go mod that needs update too
Can you please take care of that too ?
bc17bbd
to
1c6249c
Compare
Absolutely, I thought the client mod was intentionally backward, which is why I didn't update it.
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_external-snapshot-metadata/122/pull-kubernetes-csi-external-snapshot-metadata-1-30-on-kubernetes-1-30/1891743730113712128 |
@liangyuanpeng Can you please rebase the pr ? |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
1c6249c
to
c9a9260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
update go to 1.23.6 for fix CVE
https://github.com/kubernetes-csi/external-snapshot-metadata/actions/runs/13026589803/job/36336661461
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: